Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Always patch the npm registry in yarn.lock files and compute the node modules cache key after having patched them #164795

Merged
merged 1 commit into from
Oct 27, 2022

Conversation

alexdima
Copy link
Member

@alexdima alexdima commented Oct 27, 2022

When having a cache hit, we would not rewrite yarn.lock files to point to the npm registry.
This would cause problems with macOS Universal in case the x64 build would have had a cache hit and the arm64 build would have not.

…de modules cache key after having patched them
@alexdima alexdima enabled auto-merge (squash) October 27, 2022 10:13
@alexdima alexdima self-assigned this Oct 27, 2022
@vscodenpa vscodenpa added this to the October 2022 milestone Oct 27, 2022
@alexdima alexdima merged commit ba91a81 into main Oct 27, 2022
@alexdima alexdima deleted the alexd/faithful-chipmunk branch October 27, 2022 10:31
formigoni pushed a commit to formigoni/vscode that referenced this pull request Oct 27, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Dec 11, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants